feat(site): display build logs on template creation #12271
Conversation
…ild-logs-on-template-create
…ild-logs-on-template-create
There was a problem hiding this comment.
This component needs to be refactored to make it easier to extend and use #12272
There was a problem hiding this comment.
Extracted from ImportStarterTemplateView
|
FYI: Tests are on the way, I'm going to re-ask for review when pushing them but I would like to get as early feedback as possible. |
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
…ttps://github.com/coder/coder into bq/show-build-logs-on-template-create
| @@ -49,6 +49,8 @@ global.TextDecoder = TextDecoder as any; | |||
| global.Blob = Blob as any; | |||
| global.scrollTo = jest.fn(); | |||
|
|
|||
| window.HTMLElement.prototype.scrollIntoView = function () {}; | |||
There was a problem hiding this comment.
| window.HTMLElement.prototype.scrollIntoView = function () {}; | |
| window.HTMLElement.prototype.scrollIntoView = jest.fn(); |
| templateVersion: TemplateVersion | undefined, | ||
| options?: { onDone: () => Promise<unknown> }, | ||
| ) => { | ||
| const [logs, setLogs] = useState<ProvisionerJobLog[] | undefined>(); |
There was a problem hiding this comment.
I should've been more specific, but my original issue was really more wondering why we need undefined to be a unique state from []. We could reset the state by just saying setLogs([]) and the onMessage handler wouldn't need to check if logs is defined or not, it could just be simplified to setLogs((logs) => [...logs, log]).
There was a problem hiding this comment.
I use the following:
undefined- connecting[]- connected but empty
Wdyt? I use the same idea for fetching server data. query.data && <Loader /> and so on.
| ); | ||
| }; | ||
|
|
||
| const MissingVariablesBanner: FC<{ onFillVariables: () => void }> = ({ |
Demo:
Screen.Recording.2024-02-22.at.11.40.12.mov
Close #12083