fix: Write agent logs to "/tmp/coder-agent.log" for debugging #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was difficult to obtain logs for the agent if it failed to start for some reason. Now they'll go to a consistent spot!
Codecov Report
@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 66.01% 66.10% +0.09%
==========================================
Files 275 275
Lines 17949 17949
Branches 216 216
==========================================
+ Hits 11849 11866 +17
+ Misses 4859 4847 -12
+ Partials 1241 1236 -5
Continue to review full report at Codecov.
|
coadler
approved these changes
May 2, 2022
cli/agent.go
Outdated
| logger := slog.Make(sloghuman.Sink(cmd.OutOrStdout())).Leveled(slog.LevelDebug) | ||
|
|
||
| logPath := filepath.Join(os.TempDir(), "coder-agent.log") | ||
| logFile, err := os.OpenFile(logPath, os.O_CREATE|os.O_RDWR, 0600) |
There was a problem hiding this comment.
Could we add some sort of log rolling for this file just in case? For workspaces that are on for a really long time it seems like this could slowly eat up your ram forever.
There was a problem hiding this comment.
Good point. I shall add
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
It was difficult to obtain logs for the agent if it failed to start for some reason. Now they'll go to a consistent spot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was difficult to obtain logs for the agent if it failed to
start for some reason. Now they'll go to a consistent spot!