Skip to content

chore: add stories for Loader #12445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2024
Merged

chore: add stories for Loader #12445

merged 3 commits into from
Mar 8, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Mar 6, 2024

Part of #11420
Part of #12261

Snuck in a minor refactor to get rid of the FullScreenLoader component

@aslilac aslilac requested review from a team and Kira-Pilot and removed request for a team March 6, 2024 18:56
@aslilac aslilac requested a review from Kira-Pilot March 7, 2024 22:27
@aslilac
Copy link
Member Author

aslilac commented Mar 7, 2024

I just removed data-chromatic="ignore" and it didn't show a diff in Chromatic at all, so...I guess it's fine? I think it might just be black because the first/last frame is "empty" (since the spinner shrinks and grows).

@aslilac aslilac merged commit 8d8220b into main Mar 8, 2024
@aslilac aslilac deleted the add-loader-stories branch March 8, 2024 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants