-
Notifications
You must be signed in to change notification settings - Fork 889
fix: disable auto-create if external auth requirements aren't met #12538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm missing a test for this use case. |
Will disabling this point the user to authenticate with the external provider and then auto create the workspace? |
it'll just show them the normal form, and they'll have to click "create" when they've connected. |
ok, I've hit a weird block with this. I can add @BrunoQuaresma any ideas why? I tried with msw instead of mocking as well, but that had a similar problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the test and the new error helper function 👍
Closes #12491
Basically,
mode=auto
should be ignored if a required auth provider is missing