Skip to content

fix: disable auto-create if external auth requirements aren't met #12538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 19, 2024
Merged

fix: disable auto-create if external auth requirements aren't met #12538

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b5f2e89
fix: disable auto-create if external auth requirements aren't met
aslilac Mar 11, 2024
114ebe9
🧼
aslilac Mar 12, 2024
b5e7fcf
Merge branch 'main' into pause-auto-mode
aslilac Mar 12, 2024
917047e
refactor a bit
aslilac Mar 12, 2024
27281e0
re
aslilac Mar 12, 2024
e77208e
Merge branch 'main' into pause-auto-mode
aslilac Mar 13, 2024
d748276
testing
aslilac Mar 14, 2024
2992555
🤡
aslilac Mar 14, 2024
d7365e9
Merge branch 'main' into pause-auto-mode
aslilac Mar 15, 2024
ef312b2
:^)
aslilac Mar 19, 2024
3bb132c
Merge branch 'main' into pause-auto-mode
aslilac Mar 19, 2024
b601ef7
my therapist will definitely be hearing about this commit
aslilac Mar 19, 2024
dc7c722
true tho
aslilac Mar 19, 2024
92a9962
shame
aslilac Mar 19, 2024
c30988c
oejfa;oihegfiou'awrgiuhwaeoug'awikuehjfo;ia
aslilac Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
re
  • Loading branch information
@aslilac
aslilac committed Mar 12, 2024
commit 27281e01b6623af6f8525e3da0243ecb6d1cebd0
2 changes: 1 addition & 1 deletion site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const CreateWorkspacePage: FC = () => {
(!autofillEnabled || userParametersQuery.isSuccess) &&
hasAllRequiredExternalAuth;

// `mode=auto` was set, but a prequisite has failed, and so auto-mode should be abandoned.
// `mode=auto` was set, but a prerequisite has failed, and so auto-mode should be abandoned.
if (
mode === "auto" &&
!isLoadingExternalAuth &&
Expand Down