Skip to content

feat(coderd/database): use template_usage_stats in GetTemplateInsights query #12666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2024
Merged

feat(coderd/database): use template_usage_stats in GetTemplateInsights query #12666

merged 3 commits into from
Mar 25, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Mar 19, 2024 •
edited
Loading

This PR updates the GetTemplateInsights query to use rolled up template_usage_stats instead of raw agent and app stats.

@mafredri mafredri mentioned this pull request Mar 19, 2024
Merged
@mafredri Graphite App
Copy link
Member Author

mafredri commented Mar 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mafredri and the rest of your teammates on Graphite Graphite

@mafredri mafredri mentioned this pull request Mar 19, 2024
Merged
This was referenced Mar 19, 2024
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@mafredri mafredri force-pushed the mafredri/add-dbrollup-service-for-insights branch from 6364b79 to dcc3811 Compare March 19, 2024 16:24
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 45217ba to 3651195 Compare March 19, 2024 16:24
@mafredri mafredri force-pushed the mafredri/add-dbrollup-service-for-insights branch from dcc3811 to 7fc6fb5 Compare March 20, 2024 10:25
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 3651195 to 454f328 Compare March 20, 2024 10:25
mtojek
mtojek approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing concerning here

@mafredri mafredri force-pushed the mafredri/add-dbrollup-service-for-insights branch from 7fc6fb5 to 91fb8e4 Compare March 20, 2024 10:37
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 454f328 to 1e05111 Compare March 20, 2024 12:37
@mafredri mafredri changed the base branch from mafredri/add-dbrollup-service-for-insights to mafredri/fix-insights-tests-after-refactor March 20, 2024 12:37
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from b915c4c to a083bc9 Compare March 20, 2024 13:57
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch 3 times, most recently from b9c85a5 to 2d7344a Compare March 20, 2024 14:02
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from a083bc9 to 97c9a10 Compare March 20, 2024 14:53
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 2d7344a to 3b66bab Compare March 20, 2024 14:53
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from 97c9a10 to a9d5ab0 Compare March 20, 2024 16:02
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 3b66bab to dbe21aa Compare March 20, 2024 16:02
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from a9d5ab0 to f2200fb Compare March 20, 2024 19:03
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from dbe21aa to b499ab2 Compare March 20, 2024 19:04
mafredri
mafredri commented Mar 20, 2024
View reviewed changes
...data/insights/template/multiple_users_and_workspaces_three_weeks_second_template.json.golden
"template_ids": [
"00000000-0000-0000-0000-000000000002"
],
"template_ids": [],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These template ID changes in app usage is due to improved correctness.

@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from f2200fb to 3101fba Compare March 20, 2024 19:19
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from b499ab2 to b208047 Compare March 20, 2024 19:19
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from 3101fba to c9bd6af Compare March 20, 2024 19:55
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from b208047 to 4da99d8 Compare March 20, 2024 19:55
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from c9bd6af to c08f934 Compare March 21, 2024 15:06
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 4da99d8 to 33c681f Compare March 21, 2024 15:06
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from c08f934 to 22f614e Compare March 21, 2024 17:54
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 33c681f to 5c7ed09 Compare March 21, 2024 17:54
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from 22f614e to 0f423a2 Compare March 22, 2024 15:40
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 5c7ed09 to 7e229d3 Compare March 22, 2024 15:40
@mafredri mafredri mentioned this pull request Mar 22, 2024
Merged
@mafredri mafredri marked this pull request as ready for review March 22, 2024 16:38
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch from 0f423a2 to 60d812d Compare March 22, 2024 16:43
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 7e229d3 to b46a8e0 Compare March 22, 2024 17:11
@mafredri mafredri force-pushed the mafredri/fix-insights-tests-after-refactor branch 2 times, most recently from da902a8 to 9c2d085 Compare March 22, 2024 17:13
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from b46a8e0 to 87ab396 Compare March 22, 2024 17:15
Base automatically changed from mafredri/fix-insights-tests-after-refactor to main March 22, 2024 18:18
@mafredri mafredri changed the title feat(coderd/database): rewrite GetTemplateInsights to use template_usage_stats feat(coderd/database): use template_usage_stats in GetTemplateInsights query Mar 25, 2024
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsights branch from 87ab396 to 49acc52 Compare March 25, 2024 11:18
@mafredri Graphite App
Copy link
Member Author

mafredri commented Mar 25, 2024 •
edited
Loading

Merge activity

  • Mar 25, 9:33 AM EDT: @mafredri started a stack merge that includes this pull request via Graphite.
  • Mar 25, 9:33 AM EDT: @mafredri merged this pull request with Graphite.

@mafredri mafredri merged commit 35d0843 into main Mar 25, 2024
@mafredri mafredri deleted the mafredri/rewrite-gettemplateinsights branch March 25, 2024 13:33
@mafredri mafredri mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @mtojek