fix(coderd/agentapi): always write agent stats when provided #12699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
33576be to
22d4860
Compare
Previously we were discarding agent stats due to the length of connections by proto being zero.
22d4860 to
c8096db
Compare
johnstcn
approved these changes
Mar 21, 2024
deansheather
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were discarding agent stats due to the length of connections by proto being zero.
We no longer check
ConnectionsByProtobecause this can be simplified to checkStats == nildue to the agentapi v2 refactor.Previously we checked
nilnotlen:coder/coderd/workspaceagents.go
Line 1154 in 131d0bd