chore(site): clean up mocks after each test #12805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Parkreiner I did some major clean up on |
|
@code-asher I would appreciate your review on the terminal changes |
aslilac
reviewed
Mar 28, 2024
There was a problem hiding this comment.
looks good to me, but I'd like a second opinion from @Parkreiner about the useClipboard tests :)
Parkreiner
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Raised one concern about the new clipboard setup (that might already be resolved – didn't have the chance to play around with the test files)
But if it's no longer an issue, and @code-asher thinks the terminal changes look good, the PR should be good to go
|
I was not able to get to this today but I will look at it tomorrow. It does seem like at least one terminal test is failing. 🤔 |
code-asher
reviewed
Mar 29, 2024
Parkreiner
approved these changes
Apr 1, 2024
| // component. We then observe this attribute for any changes, as we cannot | ||
| // rely on other screen elements to indicate completion. | ||
| const wrapper = | ||
| utils.container.querySelector<HTMLDivElement>("[data-state]")!; | ||
| utils.container.querySelector<HTMLDivElement>("[data-status]")!; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making all mocks get fully cleaned up after each test, I realized we have a few fragile tests that may rely on previous mocks or the order of things that are running. This might take some time to "fix" things so I'm going to do this step by step so you can follow the commits.