Skip to content

chore(site): clean up mocks after each test #12805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 1, 2024
Merged

chore(site): clean up mocks after each test #12805

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3e544da
Restore all mocks after each test
BrunoQuaresma Mar 28, 2024
8d561b7
Fix and improve location of useClipboard tests
BrunoQuaresma Mar 28, 2024
30dd5c6
Fix terminal page tests
BrunoQuaresma Mar 28, 2024
5f5e453
Mute react-query console.error logs
BrunoQuaresma Mar 28, 2024
0ffaaf9
Fix act and warning errors on terminal page
BrunoQuaresma Mar 28, 2024
0e73724
Fix fmt
BrunoQuaresma Mar 28, 2024
d9569cb
Refactor useEffect deps
BrunoQuaresma Mar 28, 2024
b1fb0b3
Rename terminal state to connection status
BrunoQuaresma Apr 1, 2024
24cf212
Make the terminal a state
BrunoQuaresma Apr 1, 2024
26e7a9d
Remove config.isLoading from deps
BrunoQuaresma Apr 1, 2024
91abb66
Rollback config is loading
BrunoQuaresma Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rollback config is loading
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Apr 1, 2024
commit 91abb66153e5d4da62ea20b6381ed229964fe38e
4 changes: 2 additions & 2 deletions site/src/pages/TerminalPage/TerminalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const TerminalPage: FC = () => {
// Create the terminal!
const fitAddonRef = useRef<FitAddon>();
useEffect(() => {
if (!terminalWrapperRef.current || !renderer) {
if (!terminalWrapperRef.current || config.isLoading) {
return;
}
const terminal = new XTerm.Terminal({
Expand Down Expand Up @@ -135,7 +135,7 @@ const TerminalPage: FC = () => {
window.removeEventListener("resize", listener);
terminal.dispose();
};
}, [renderer, theme.palette.background.default]);
}, [config.isLoading, renderer, theme.palette.background.default]);

// Updates the reconnection token into the URL if necessary.
useEffect(() => {
Expand Down