Skip to content

test: verify actually uploaded license with assert #12934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2024
Merged

test: verify actually uploaded license with assert #12934

merged 1 commit into from
Apr 10, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 10, 2024

Prior page.GetByText did not assert it existed. This would always pass, even if your license was invalid.

@Emyrk
test: verify actually uploaded license with assert
22f42eb 
Prior page.GetByText did not assert it existed
@Emyrk Emyrk requested a review from aslilac April 10, 2024 21:14
@aslilac
Copy link
Member

aslilac commented Apr 10, 2024

ah, thank you. my bad. 😅

@Emyrk Emyrk merged commit 8da8b89 into main Apr 10, 2024
25 checks passed
@Emyrk Emyrk deleted the stevenmasley/e2e_setup branch April 10, 2024 23:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @aslilac