Skip to content

chore: deprecate gauge metrics with _total suffix (#12744) #12976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2024
Merged

chore: deprecate gauge metrics with _total suffix (#12744) #12976

merged 3 commits into from
Apr 24, 2024

Conversation

snark87
Copy link
Contributor

@snark87 snark87 commented Apr 16, 2024 •
edited
Loading

Fixes #12744

Deprecated metrics:

  • coderd_oauth2_external_requests_rate_limit_total
  • coderd_api_workspace_latest_build_total

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Apr 16, 2024
@snark87
chore: deprecate gauge metrics with _total suffix (coder#12744)
ae1b62c 
Deprecated metrics:
- coderd_oauth2_external_requests_rate_limit_total
- coderd_api_workspace_latest_build_total
@snark87 snark87 force-pushed the deprecated-metrics branch from 98577e5 to ae1b62c Compare April 16, 2024 16:07
@kylecarbs kylecarbs requested a review from johnstcn April 17, 2024 17:32
@snark87 snark87 marked this pull request as ready for review April 18, 2024 04:30
dannykopping
dannykopping approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @snark87! Thank you very much for your contribution

@johnstcn johnstcn mentioned this pull request Apr 18, 2024
Open
johnstcn
johnstcn approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Created a follow-up issue to track deprecation.

@johnstcn
Copy link
Member

@snark87 can you please merge latest main? There's an issue with one of the tests that has been worked around here: coder/internal#101

snark87 and others added 2 commits April 18, 2024 14:10
@snark87
Merge remote-tracking branch 'origin/main' into deprecated-metrics
39c45e6
@snark87 @johnstcn
Apply suggestions from code review
5a948fe 
add link to follow-up issue

Co-authored-by: Cian Johnston <public@cianjohnston.ie>
@snark87
Copy link
Contributor Author

snark87 commented Apr 18, 2024 •
edited
Loading

@snark87 can you please merge latest main? There's an issue with one of the tests that has been worked around here: coder/internal#101
@johnstcn Done, CI is green now.

@matifali matifali merged commit 4682355 into coder:main Apr 24, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@snark87 snark87

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate gauge metrics named like counters
4 participants
@snark87 @johnstcn @dannykopping @matifali