Skip to content

feat: influence parameter defaults through cli flag/env #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

aaronlehmann
Copy link
Contributor

Add a --parameter-default flag / CODER_RICH_PARAMETER_DEFAULT environment variable which overrides default values suggested for parameters.

This allows scripts or middleware wrapping the CLI to substitute defaults for parameter values beyond those defined at the template level. For example, Git repository/branch parameters can be given defaults based on the current checkout, or default parameter values can be parsed out of files inside the repo.

Add a --parameter-default flag / CODER_RICH_PARAMETER_DEFAULT
environment variable which overrides default values suggested for
parameters.

This allows scripts or middleware wrapping the CLI to substitute
defaults for parameter values beyond those defined at the template
level. For example, Git repository/branch parameters can be given
defaults based on the current checkout, or default parameter values can
be parsed out of files inside the repo.
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Apr 22, 2024
@aaronlehmann
Copy link
Contributor Author

The original title does not begin with a verb. It explains an action being carried out, rather than the changes being made.
The correct form should start with a verb, indicating the action taken in the pull request.

"influence" is a verb :(

@aaronlehmann
Copy link
Contributor Author

Hi @mafredri, would you be the right person to review this one? Thanks in advance!

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kylecarbs kylecarbs enabled auto-merge (squash) April 29, 2024 18:12
@kylecarbs kylecarbs disabled auto-merge April 29, 2024 18:23
@kylecarbs kylecarbs merged commit 0e3dc2a into coder:main Apr 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests and issues created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants