-
Notifications
You must be signed in to change notification settings - Fork 881
chore(scripts): add script to promote mainline to stable #13054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3013aeb
to
3fa197b
Compare
02aac99
to
0e2e866
Compare
Do we plan to automate this table, too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean script 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor notes, LGTM
scripts/release/main.go
Outdated
PerPage: perPage, | ||
}) | ||
if err != nil { | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest wrapping this error or adding a log line before it showing what the current action is
scripts/release/main.go
Outdated
if err != nil { | ||
return err | ||
} | ||
logger.Info(ctx, "selected version promoted to stable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a link to the release in the output for convenience?
body: `## Changelog | ||
|
||
> [!NOTE] | ||
> This is a mainline Coder release. We advise enterprise customers without a staging environment to install our [latest stable release](https://github.com/coder/coder/releases/latest) while we refine this version. Learn more about our [Release Schedule](https://coder.com/docs/v2/latest/install/releases). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be illustrative / more complete to add a test which shows that multiple lines subsequent to [!NOTE]
prefixed with >
are removed; we'll likely amend this note in the future.
Should these PRs be chore as it's not a user facing feature? It would end up as features in our changelog. |
That’s fair. I’ll change them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
654add1
to
6898381
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
// Example: | ||
// | ||
// > ## Stable (since April 23, 2024) | ||
func addStableSince(date time.Time, body string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
Fixes #12459
Example dry-run:
Example dry-run for non-latest version:
Note: This PR does not yet update docs to reflect the promoted version. This will be part of #12465.