Skip to content

ci: fix syntax issue in docker-base.yaml #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2024
Merged

ci: fix syntax issue in docker-base.yaml #13412

merged 2 commits into from
May 30, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented May 30, 2024 •
edited
Loading

continuation of #13409

@matifali
run on workflow changes
7712e3a 
This should ensure the workflow runs fine before merging into `main`
@matifali matifali marked this pull request as ready for review May 30, 2024 08:44
deansheather
deansheather approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

dannykopping
dannykopping approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up, I think we should look into a github action linter to catch these problems pre-merge in the future.

Thanks for fixing @matifali 👍

@matifali matifali mentioned this pull request May 30, 2024
Closed
@matifali matifali enabled auto-merge (squash) May 30, 2024 08:48
@matifali matifali merged commit 7a7bef0 into main May 30, 2024
@matifali matifali deleted the docker-base-syntax branch May 30, 2024 08:49
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matifali @dannykopping @deansheather