chore: implement typed database for custom permissions (breaks existing custom roles) #13457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing the previous raw json.
Emyrk
commented
Jun 3, 2024
Comment on lines
+1788
to
+1790
| SitePermissions CustomRolePermissions `db:"site_permissions" json:"site_permissions"` | ||
| OrgPermissions CustomRolePermissions `db:"org_permissions" json:"org_permissions"` | ||
| UserPermissions CustomRolePermissions `db:"user_permissions" json:"user_permissions"` |
There was a problem hiding this comment.
So much better than json.RawMessage
johnstcn
approved these changes
Jun 4, 2024
Comment on lines
+1
to
+3
| -- Previous custom roles are now invalid, as the json changed. Since this is an | ||
| -- experimental feature, there is no point in trying to save the perms. | ||
| -- This does not elevate any permissions, so it is not a security issue. |
There was a problem hiding this comment.
Might be no harm to call this out in case adventurous folks are already playing around with this.
There was a problem hiding this comment.
I added it in the PR description and the commit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom roles in the db were raw json. Using sqlc overrides, I can make these typed which is much better. This is just a refactor. Fixed up the tests to match.
Forgot this was something we could easily do. It removes some converting that we used to have to do.
Any existing custom org roles will be replaced with 0 permissions. This is a change in format.