Skip to content

chore: implement typed database for custom permissions (breaks existing custom roles) #13457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2024
Merged

chore: implement typed database for custom permissions (breaks existing custom roles) #13457

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff7fa1c
chore: typed database custom permissions
Emyrk Jun 3, 2024
6efc8d6
add migration to fix any custom roles out there
Emyrk Jun 3, 2024
4354636
fixup
Emyrk Jun 3, 2024
e4ca59b
fixup
Emyrk Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add migration to fix any custom roles out there
  • Loading branch information
@Emyrk
Emyrk committed Jun 3, 2024
commit 6efc8d6d19e940beae4591d16b7852940b962bd9
1 change: 1 addition & 0 deletions coderd/database/migrations/000214_org_custom_role_array.down.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
UPDATE custom_roles SET org_permissions = '{}';
4 changes: 4 additions & 0 deletions coderd/database/migrations/000214_org_custom_role_array.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
-- Previous custom roles are now invalid, as the json changed. Since this is an
-- experimental feature, there is no point in trying to save the perms.
-- This does not elevate any permissions, so it is not a security issue.
Comment on lines +1 to +3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be no harm to call this out in case adventurous folks are already playing around with this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it in the PR description and the commit.

UPDATE custom_roles SET org_permissions = '[]';
Loading