Skip to content

fix: Allow coderd to exit on error channel #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

fix: Allow coderd to exit on error channel #1355

merged 1 commit into from
May 10, 2022

Conversation

kylecarbs
Copy link
Member

coderd would fail silently if this was called, because connections
would never drain. HashiCorp's hc-install package broke today,
and we couldn't notice because this was hanging!

@kylecarbs
fix: Allow coderd to exit on error channel
320110c 
coderd would fail silently if this was called, because connections
would never drain. HashiCorp's hc-install package broke today,
and we couldn't notice because this was hanging!
@kylecarbs kylecarbs requested a review from coadler May 10, 2022 02:07
@kylecarbs kylecarbs self-assigned this May 10, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) May 10, 2022 02:09
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #1355 (320110c) into main (3660483) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   67.03%   66.83%   -0.21%     
==========================================
  Files         284      280       -4     
  Lines       18529    18330     -199     
  Branches      235      235              
==========================================
- Hits        12421    12250     -171     
+ Misses       4844     4826      -18     
+ Partials     1264     1254      -10
Flag Coverage Δ
unittest-go-macos-latest 54.06% <0.00%> (-0.20%) ⬇️
unittest-go-postgres- 65.61% <0.00%> (-0.12%) ⬇️
unittest-go-ubuntu-latest 56.59% <0.00%> (-0.04%) ⬇️
unittest-go-windows-2022 ?
unittest-js 73.67% <ø> (ø)
Impacted Files Coverage Δ
cli/server.go 57.48% <0.00%> (-0.10%) ⬇️
cli/configssh.go 62.58% <0.00%> (-6.48%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/cliui/agent.go 77.46% <0.00%> (-4.23%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peer/conn.go 79.85% <0.00%> (-2.71%) ⬇️
agent/agent.go 64.66% <0.00%> (-2.48%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
coderd/workspaceagents.go 56.04% <0.00%> (-1.87%) ⬇️
provisionerd/provisionerd.go 75.76% <0.00%> (-0.54%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3660483...320110c. Read the comment docs.

@kylecarbs kylecarbs merged commit e6f1ce1 into main May 10, 2022
@kylecarbs kylecarbs deleted the surfaceerror branch May 10, 2022 02:19
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Allow coderd to exit on error channel (#1355)
c4c8348 
coderd would fail silently if this was called, because connections
would never drain. HashiCorp's hc-install package broke today,
and we couldn't notice because this was hanging!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @coadler @misskniss