Skip to content

fix: Allow coderd to exit on error channel #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

fix: Allow coderd to exit on error channel #1355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Allow coderd to exit on error channel 
coderd would fail silently if this was called, because connections
would never drain. HashiCorp's hc-install package broke today,
and we couldn't notice because this was hanging!
  • Loading branch information
@kylecarbs
kylecarbs committed May 10, 2022
commit 320110cd613275c9ef685c3ef808c7036b47778e
1 change: 1 addition & 0 deletions cli/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ func server() *cobra.Command {
return err
}
case err := <-errCh:
shutdownConns()
closeCoderd()
return err
case <-stopChan:
Expand Down