feat: Add update user roles action #1361
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
+ Coverage 66.49% 66.95% +0.46%
==========================================
Files 284 286 +2
Lines 18593 18752 +159
Branches 235 241 +6
==========================================
+ Hits 12363 12555 +192
+ Misses 4964 4913 -51
- Partials 1266 1284 +18
Continue to review full report at Codecov.
|
Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
There was a problem hiding this comment.
My brain is a little fried so I'm not looking as deeply at the XService as normal but this all looks good to me. I just have a question about your useRoles hook - if it's taking effect at the same time as the other useEffect seems like we could put them together. If not then maybe the other one (that I wrote) has a bug.
Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
|
@presleyp thanks for the review. About the |
|
@BrunoQuaresma yeah, I think that's a strategy for addressing the thing that bothers me about |
| @@ -0,0 +1,24 @@ | |||
| import { ComponentMeta, Story } from "@storybook/react" | |||
| import React from "react" | |||
There was a problem hiding this comment.
@BrunoQuaresma Just looking at merged PRs to learn - no action necessary here. Curious if there's a reason we're importing React given we're on version 17 instead of silencing the 'React must be in scope' warnings.
There was a problem hiding this comment.
Good question, I think it is automatically added by an eslint role, but I'm not 100% sure.
Closes #739