Skip to content

feat: Add update user roles action #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 10, 2022
Merged

feat: Add update user roles action #1361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
32cba83
Load roles and show them in the table
BrunoQuaresma May 6, 2022
b167995
Update types
BrunoQuaresma May 6, 2022
cabe385
Update API
BrunoQuaresma May 6, 2022
b71ede5
Update roles to fetch the site roles
BrunoQuaresma May 6, 2022
d5e749f
Merge branch 'main' of github.com:coder/coder into bq/fe/update-user-…
BrunoQuaresma May 9, 2022
1e99a04
Add UI for update user roles
BrunoQuaresma May 9, 2022
46add41
Set fixed RoleSelect width
BrunoQuaresma May 9, 2022
16d1e7b
Fix UI to update user roles
BrunoQuaresma May 9, 2022
1e93bd2
Do not display the success notification
BrunoQuaresma May 9, 2022
82a60f8
Add role select storybook
BrunoQuaresma May 10, 2022
9c0587e
Add missing tests
BrunoQuaresma May 10, 2022
c7c7b95
Add fail test case
BrunoQuaresma May 10, 2022
a01cb87
Update site/src/components/RoleSelect/RoleSelect.tsx
BrunoQuaresma May 10, 2022
f402da0
Update site/src/components/RoleSelect/RoleSelect.tsx
BrunoQuaresma May 10, 2022
9f47873
Update site/src/pages/UsersPage/UsersPage.test.tsx
BrunoQuaresma May 10, 2022
6cf12b5
Clear get roles error
BrunoQuaresma May 10, 2022
16c3fe3
Fix storybook
BrunoQuaresma May 10, 2022
9bd6ca5
Add comment about fetch the roles
BrunoQuaresma May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix UI to update user roles
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 9, 2022
commit 16d1e7b0b54e08c86ce1a31eb500696e5f90c118
5 changes: 3 additions & 2 deletions site/src/components/UsersTable/RoleSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const RoleSelect: React.FC<RoleSelectProps> = ({ roles, selectedRoles, lo
const styles = useStyles()
const value = selectedRoles.map((r) => r.name)
const renderValue = () => selectedRoles.map((r) => r.display_name).join(", ")
const sortedRoles = roles.sort((a, b) => a.display_name.localeCompare(b.display_name))

return (
<Select
Expand All @@ -25,11 +26,11 @@ export const RoleSelect: React.FC<RoleSelectProps> = ({ roles, selectedRoles, lo
variant="outlined"
className={styles.select}
onChange={(e) => {
const { value } = e.currentTarget
const { value } = e.target
onChange(value as string[])
}}
>
{roles.map((r) => {
{sortedRoles.map((r) => {
const isChecked = selectedRoles.some((selectedRole) => selectedRole.name === r.name)

return (
Expand Down
5 changes: 2 additions & 3 deletions site/src/xServices/users/usersXService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ export const usersMachine = createMachine(
displayError(Language.resetUserPasswordError)
},
displayUpdateRolesSuccess: () => {
displayError(Language.updateUserRolesSuccess)
displaySuccess(Language.updateUserRolesSuccess)
},
displayUpdateRolesErrorMessage: () => {
displayError(Language.updateUserRolesError)
Expand All @@ -317,8 +317,7 @@ export const usersMachine = createMachine(
return users
}

const updatedUser = event.data
return users.map((u) => (u.id === updatedUser.id ? updatedUser : u))
return users.map((u) => (u.id === event.data.id ? event.data : u))
},
}),
},
Expand Down