feat: add groups and group members to telemetry snapshot #13655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
austinrhode
commented
Jun 24, 2024
- Updated Telemetry data to also send a list of groups and a list of group members
…gic to ignore non-active users when creating a snapshot
|
All contributors have signed the CLA ✍️ ✅ |
coadler
approved these changes
Jun 24, 2024
| @@ -353,9 +353,6 @@ func (r *remoteReporter) createSnapshot() (*Snapshot, error) { | |||
| users := database.ConvertUserRows(userRows) | |||
| var firstUser database.User | |||
| for _, dbUser := range users { | |||
| if dbUser.Status != database.UserStatusActive { | |||
| continue | |||
| } | |||
There was a problem hiding this comment.
It looks like this is from your previous pr #13613
coderd/telemetry/telemetry.go
Outdated
| } | ||
| } | ||
|
|
||
| func ConvertGroupMember(group_member database.GroupMember) GroupMember { |
There was a problem hiding this comment.
Don't use underscores in go vars.
Suggested change
| func ConvertGroupMember(group_member database.GroupMember) GroupMember { | |
| func ConvertGroupMember(member database.GroupMember) GroupMember { |
|
I have read the CLA Document and I hereby sign the CLA |
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.