feat: add "Full Name" field to user creation #13659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to specify "Full Name" (a.k.a. Name) when creating users either via CLI or UI.
2e68b76 to
0ec27e9
Compare
johnstcn
commented
Jun 25, 2024
| @@ -20,6 +21,8 @@ export const Language = { | |||
| emailLabel: "Email", | |||
| passwordLabel: "Password", | |||
| usernameLabel: "Username", | |||
| nameLabel: "Full name", | |||
There was a problem hiding this comment.
Nit: I would use "Name" instead of "Full name".
There was a problem hiding this comment.
Again, I would much prefer to use "full name" in the UI/CLI to distinguish it from "username". The API refers to it as name however.
There was a problem hiding this comment.
❤️ for adding e2e tests
BrunoQuaresma
approved these changes
Jun 25, 2024
mtojek
approved these changes
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13490
Continued from #13491
Adds the ability to specify "Full Name" (a.k.a. Name) when creating users either via CLI or UI.