Skip to content

ci: test with multiple postgres versions #13665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 26, 2024
Merged

ci: test with multiple postgres versions #13665

merged 10 commits into from
Jun 26, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 25, 2024 •
edited
Loading

  • Tests now run on postgres 16 by default when run locally (can be specified with POSTGRES_VERSION)
  • Adds test-go-pg-16 to test against postgres version 16
  • Updates Dogfood dockerfile / nix flake to postgres version 16
  • Updates docker-compose.yaml postgres tag to 16

@johnstcn johnstcn self-assigned this Jun 25, 2024
@johnstcn johnstcn marked this pull request as ready for review June 25, 2024 18:55
@johnstcn johnstcn changed the title chore(Makefile): use postgres 16 for tests ci: test with multiple postgres versions Jun 26, 2024
@matifali
Copy link
Member

Should we bump postgress version in dogfood Dockerfile and nix.flake too?

@matifali
Copy link
Member

Also you may like to answer #13438.

@johnstcn
Copy link
Member Author

I'm going to leave our embedded postgres version at 13; updating that with no warning may cause sadness.

@johnstcn johnstcn requested review from coadler and deansheather June 26, 2024 14:00
deansheather
deansheather reviewed Jun 26, 2024
View reviewed changes
@johnstcn johnstcn requested review from deansheather and Emyrk June 26, 2024 14:42
Emyrk
Emyrk approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Are we asking customers to upgrade to 16?

@johnstcn
Copy link
Member Author

👍 Are we asking customers to upgrade to 16?

Nope, folks are asking if 16 is supported.

@johnstcn johnstcn merged commit 20e59e0 into main Jun 26, 2024
37 of 39 checks passed
@johnstcn johnstcn deleted the cj/postgres-16 branch June 26, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@deansheather deansheather deansheather approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnstcn @matifali @Emyrk @deansheather