Skip to content

ci: test with multiple postgres versions #13665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 26, 2024
Merged

ci: test with multiple postgres versions #13665

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a38bc43
chore(Makefile): use postgres 16 for tests
johnstcn Jun 25, 2024
4201130
test-postgres matrix
johnstcn Jun 26, 2024
eef466f
more curly braces
johnstcn Jun 26, 2024
3fcdef4
dokcer-compose.yaml: update postgres version
johnstcn Jun 26, 2024
adb56ef
makefile: name test container based on pg version
johnstcn Jun 26, 2024
3c23423
update postgres version
johnstcn Jun 26, 2024
d0ac96a
fixup! dokcer-compose.yaml: update postgres version
johnstcn Jun 26, 2024
6c32fb3
update flake.nix
johnstcn Jun 26, 2024
ef8135a
fixup! dokcer-compose.yaml: update postgres version
johnstcn Jun 26, 2024
6bc8744
ci: make a separate job instead of using matrix
johnstcn Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci: make a separate job instead of using matrix
  • Loading branch information
@johnstcn
johnstcn committed Jun 26, 2024
commit 6bc8744fe52eeb399a392262d0cf48f6de8e31e8
47 changes: 41 additions & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,6 @@ jobs:
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
needs:
- changes
strategy:
matrix:
POSTGRES_VERSION:
- "13"
- "16"
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
Expand All @@ -354,7 +349,47 @@ jobs:

- name: Test with PostgreSQL Database
env:
POSTGRES_VERSION: "${{ matrix.POSTGRES_VERSION }}"
POSTGRES_VERSION: "13"
TS_DEBUG_DISCO: "true"
run: |
make test-postgres

- name: Upload test stats to Datadog
timeout-minutes: 1
continue-on-error: true
uses: ./.github/actions/upload-datadog
if: success() || failure()
with:
api-key: ${{ secrets.DATADOG_API_KEY }}

# NOTE: this could instead be defined as a matrix strategy, but we want to
# only block merging if tests on postgres 13 fail. Using a matrix strategy
# here makes the check in the above `required` job rather complicated.
test-go-pg-16:
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
needs:
- changes
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
# goroutines. Setting this to the timeout +5m should work quite well
# even if some of the preceding steps are slow.
timeout-minutes: 25
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 1

- name: Setup Go
uses: ./.github/actions/setup-go

- name: Setup Terraform
uses: ./.github/actions/setup-tf

- name: Test with PostgreSQL Database
env:
POSTGRES_VERSION: "16"
TS_DEBUG_DISCO: "true"
run: |
make test-postgres
Expand Down
Loading