Skip to content

fix: disable agent app buttons while a blocking startup script is running #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jun 25, 2024

From a customer in Zendesk (loosely paraphrased)

The behavior we would like to have is for coder_app​ resources to not be accessible until after the startup script has completed. To do this, I've set startup_script_behavior​ to "blocking"​ in our templates. The startup_script_behavior documentation, says this means that the workspace is "not ready", which I would expect to mean that you can't yet do things like click on apps.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a test to ensure we don't change this in the future accidentally.

@aslilac aslilac requested a review from BrunoQuaresma June 26, 2024 20:51
@aslilac aslilac merged commit 8b615f4 into main Jun 27, 2024
29 checks passed
@aslilac aslilac deleted the apps-wait-for-ready branch June 27, 2024 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants