Skip to content

chore: implement sane default pagination limit for audit logs #13676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2024
Merged

chore: implement sane default pagination limit for audit logs #13676

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95185e7
chore: implement sane default pagination limit for audit logs
Emyrk Jun 26, 2024
41561cb
add unit test
Emyrk Jun 26, 2024
c1c14e6
add comment to protect 0 as limit
Emyrk Jun 26, 2024
bb2e7fc
compile fix
Emyrk Jun 26, 2024
28c3872
make gne
Emyrk Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add unit test
  • Loading branch information
@Emyrk
Emyrk committed Jun 26, 2024
commit 41561cb20824e7cc7333d18edf374c734da2e37a
23 changes: 23 additions & 0 deletions coderd/database/querier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,29 @@ func TestDefaultOrg(t *testing.T) {
require.True(t, all[0].IsDefault, "first org should always be default")
}

func TestAuditLogDefaultLimit(t *testing.T) {
t.Parallel()
if testing.Short() {
t.SkipNow()
}

sqlDB := testSQLDB(t)
err := migrations.Up(sqlDB)
require.NoError(t, err)
db := database.New(sqlDB)

for i := 0; i < 110; i++ {
dbgen.AuditLog(t, db, database.AuditLog{})
}

ctx := testutil.Context(t, testutil.WaitShort)
rows, err := db.GetAuditLogsOffset(ctx, database.GetAuditLogsOffsetParams{})
require.NoError(t, err)
// The length should match the default limit of the SQL query.
// Updating the sql query requires changing the number below to match.
require.Len(t, rows, 100)
}

// TestReadCustomRoles tests the input params returns the correct set of roles.
func TestReadCustomRoles(t *testing.T) {
t.Parallel()
Expand Down