Skip to content

chore: implement sane default pagination limit for audit logs #13676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2024
Merged

chore: implement sane default pagination limit for audit logs #13676

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95185e7
chore: implement sane default pagination limit for audit logs
Emyrk Jun 26, 2024
41561cb
add unit test
Emyrk Jun 26, 2024
c1c14e6
add comment to protect 0 as limit
Emyrk Jun 26, 2024
bb2e7fc
compile fix
Emyrk Jun 26, 2024
28c3872
make gne
Emyrk Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment to protect 0 as limit
  • Loading branch information
@Emyrk
Emyrk committed Jun 26, 2024
commit c1c14e66676799a393fe97908a8af89d714b9a8f
6 changes: 4 additions & 2 deletions coderd/pagination.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ func parsePagination(w http.ResponseWriter, r *http.Request) (p codersdk.Paginat
parser := httpapi.NewQueryParamParser()
params := codersdk.Pagination{
AfterID: parser.UUID(queryParams, uuid.Nil, "after_id"),
Limit: int(parser.PositiveInt32(queryParams, 0, "limit")),
Offset: int(parser.PositiveInt32(queryParams, 0, "offset")),
// A limit of 0 should be interpreted by the SQL query as "null" or
// "no limit". Do not make this value anything besides 0.
Limit: int(parser.PositiveInt32(queryParams, 0, "limit")),
Offset: int(parser.PositiveInt32(queryParams, 0, "offset")),
Comment on lines +20 to +23
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this comment similar to the -1 one before. Should clear it up going forward 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this comment directly contradict what happens in auditlogs.sql?

}
if len(parser.Errors) > 0 {
httpapi.Write(ctx, w, http.StatusBadRequest, codersdk.Response{
Expand Down