Skip to content

feat: add members settings page for organizations #13817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 16, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jul 8, 2024

No description provided.

@aslilac aslilac marked this pull request as draft July 8, 2024 14:49
@aslilac aslilac marked this pull request as ready for review July 11, 2024 19:41
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Just missing tests for the feature.

@BrunoQuaresma
Copy link
Collaborator

QA results:

  • I removed myself, the owner, from the organization members, which broke Coder.
  • Nit: Even with added members in the org, they are showing in the "add new member" select. Maybe it would be better to hide the ones that are already added?
  • Nit: The remove option does not require any extra action, so I would remove the "..."

@aslilac
Copy link
Member Author

aslilac commented Jul 15, 2024

the way we've budgeted it, I'm gonna work on tests towards the end of the next sprint to make sure we don't have to slip the deadline.

@aslilac aslilac requested a review from BrunoQuaresma July 15, 2024 19:36
@jaaydenh
Copy link
Contributor

Not a high priority but it seems like it would be simpler to not show users already in the organization in the add user dropdown.

@aslilac
Copy link
Member Author

aslilac commented Jul 16, 2024

that's not practically possible right now. some orgs will have thousands of members, and it would require a new backend endpoint that could return only users which are not in that set. if we did the filtering on the client side, you could easily end up in a situation where the first 25 users that we query are all in the org, and we'd have to send another request....and another....and another.

if we ever do this, it'll have to be later. it'd be a lot of work to get right, and low reward imo.

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from tests which can be added later, lgtm

@aslilac aslilac merged commit a3f40d5 into main Jul 16, 2024
32 checks passed
@aslilac aslilac deleted the org-members-page branch July 16, 2024 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants