fix(cli): do not overwrite repeated SSH options in config-ssh #13819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65d83f2 to
8e131eb
Compare
|
Just to make sure I understand, this is because you can have multiple TIL keys can be duplicated. |
Yeah, they're additive in the case of |
Emyrk
approved these changes
Jul 8, 2024
kylecarbs
approved these changes
Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
config-sshsuch that it relies on SSH config option prioritization (first come, first served) to retain the behavior when options supporting multiple entries are defined. We also retain the ability to remove options by setting them to an empty value. Removal is perhaps the strangest part of this, and ultimately we may be better served by a different method of removing an option, but I think this is fine for now.Fixes #11593