Skip to content

fix(cli): do not overwrite repeated SSH options in config-ssh #13819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix(cli): do not overwrite repeated SSH options in config-ssh #13819

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ada21
fix(cli): do not overwrite repeated SSH options in config-ssh
mafredri Jul 8, 2024
8e131eb
fix test and case insensitivity
mafredri Jul 8, 2024
bec1f01
improve comment
mafredri Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve comment
  • Loading branch information
@mafredri
mafredri committed Jul 8, 2024
commit bec1f01e3a5bb06958f357f95686507529cdf879
2 changes: 1 addition & 1 deletion cli/configssh_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ func Test_sshConfigOptions_addOption(t *testing.T) {
},
Add: []string{
"b c",
"a=", // Remove all entries that start with "a", i.e. next line.
"a ", // Empty value, means remove all following entries that start with "a", i.e. next line.
"A hello",
"hello world",
},
Expand Down