chore: remove references to restarting/stopping in update workspace language #13852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terraform apply will just apply the start state.
Kira-Pilot
reviewed
Jul 9, 2024
| confirmText="Update" | ||
| description={ | ||
| <Stack> | ||
| <p> | ||
| Restarting your workspace will stop all running processes and{" "} | ||
| Updating your workspace will stop all running processes and{" "} |
There was a problem hiding this comment.
Suggested change
| Updating your workspace will stop all running processes and{" "} | |
| Updating your workspace will{" "} |
stop all running processes is kind of misleading, right?
There was a problem hiding this comment.
You are right. I am having some trouble trying to find the difference between our phrasing of "updating" vs the actual terraform actions 🤔
|
Also updated the batch update wording. Just saw that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terraform apply will just apply the start state. The differences should be detected by terraform, and the workspace will be updated.
The confusion is that we do have a UI and a cli
coder restartthat does issue astop, starttransition. Update does not do this.