Skip to content

chore: remove references to restarting/stopping in update workspace language #13852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024
Merged

chore: remove references to restarting/stopping in update workspace language #13852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c54246
chore: remove language for update that mentions stopping
Emyrk Jul 9, 2024
3a2587f
reword updating workspaces to remove the word "restart"
Emyrk Jul 9, 2024
f842dab
update wording
Emyrk Jul 9, 2024
6bcb8d4
fix batch wording
Emyrk Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions docs/workspaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,11 @@ manually updated the workspace.
## Updating workspaces

After updating the default version of the template that a workspace was created
from, you can update the workspace.
from, you can update the workspace. Coder will start the workspace with said
version.

![Updating a workspace](./images/workspace-update.png)

If the workspace is running, Coder stops it, updates it, then starts the
workspace again.

On the command line:

```shell
Expand Down
5 changes: 3 additions & 2 deletions site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,13 @@ export const WorkspaceReadyPage: FC<WorkspaceReadyPageProps> = ({
setIsConfirmingUpdate(false);
}}
onClose={() => setIsConfirmingUpdate(false)}
title="Update and restart?"
title="Update workspace?"
confirmText="Update"
description={
<Stack>
<p>
Restarting your workspace will stop all running processes and{" "}
Updating your workspace will start the workspace on the latest
template version. This can{" "}
<strong>delete non-persistent data</strong>.
</p>
{latestVersion?.message && (
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/WorkspacesPage/BatchUpdateConfirmation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ const Consequences: FC<ConsequencesProps> = ({ runningWorkspaces }) => {
<p>You are about to update {workspaceCount}.</p>
<ul css={styles.consequences}>
<li>
Updating will stop all running processes and delete non-persistent
data.
Updating will start workspaces on their latest template versions. This
can delete non-persistent data.
</li>
<li>
Anyone connected to a running workspace will be disconnected until the
Expand Down
Loading