-
Notifications
You must be signed in to change notification settings - Fork 905
feat: add SMTP auth & TLS support #13902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
e0d02be
to
3533d90
Compare
Signed-off-by: Danny Kopping <danny@coder.com>
3533d90
to
e987643
Compare
@@ -2121,7 +2158,7 @@ Write out the current server config as YAML to stdout.`, | |||
Value: &c.Notifications.DispatchTimeout, | |||
Default: time.Minute.String(), | |||
Group: &deploymentGroupNotifications, | |||
YAML: "dispatch-timeout", | |||
YAML: "dispatchTimeout", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by: fixing previous mistakes of mine.
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you done a trial with Google account?
Yup, and with outlook.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Danny Kopping <danny@coder.com>
…ort it Signed-off-by: Danny Kopping <danny@coder.com>
@mtojek heads up, added this after your review: 4f7a910 Changed the email template to use a hosted logo since SVG support in email clients is still pitiful. |
what about embedded PNG/base64 image? |
Tried that too, it shows like this: ![]() |
Crap, that's bad. I'm wondering if we shouldn't host it on our site rather than on GitHub. I don't know if these raw links are stable API. |
Relies on coder/coder.com#518 Signed-off-by: Danny Kopping <danny@coder.com>
I've created https://github.com/coder/coder.com/pull/518 and referenced the new URL in 5a8331f |
Closes coder/internal#1
Partially addresses coder/internal#5
Also changed the email template to use a hosted logo since SVG support in email clients is still pitiful.