Skip to content

feat: add SMTP auth & TLS support #13902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 19, 2024
Merged

Conversation

dannykopping
Copy link
Contributor

@dannykopping dannykopping commented Jul 16, 2024

Closes coder/internal#1
Partially addresses coder/internal#5

Also changed the email template to use a hosted logo since SVG support in email clients is still pitiful.

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the dk/system-notifications-smtp branch from e0d02be to 3533d90 Compare July 16, 2024 10:34
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the dk/system-notifications-smtp branch from 3533d90 to e987643 Compare July 16, 2024 10:36
@@ -2121,7 +2158,7 @@ Write out the current server config as YAML to stdout.`,
Value: &c.Notifications.DispatchTimeout,
Default: time.Minute.String(),
Group: &deploymentGroupNotifications,
YAML: "dispatch-timeout",
YAML: "dispatchTimeout",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by: fixing previous mistakes of mine.

@dannykopping dannykopping changed the title WIP feat: add SMTP auth & TLS support feat: add SMTP auth & TLS support Jul 16, 2024
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping marked this pull request as ready for review July 16, 2024 13:40
@dannykopping dannykopping requested review from mafredri and mtojek July 16, 2024 13:40
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you done a trial with Google account?

@dannykopping
Copy link
Contributor Author

Have you done a trial with Google account?

Yup, and with outlook.com

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
…ort it

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping
Copy link
Contributor Author

@mtojek heads up, added this after your review: 4f7a910

Changed the email template to use a hosted logo since SVG support in email clients is still pitiful.

@mtojek
Copy link
Member

mtojek commented Jul 18, 2024

Changed the email template to use a hosted logo since SVG support in email clients is still pitiful.

what about embedded PNG/base64 image?

@dannykopping
Copy link
Contributor Author

Changed the email template to use a hosted logo since SVG support in email clients is still pitiful.

what about embedded PNG/base64 image?

Tried that too, it shows like this:

image

@mtojek
Copy link
Member

mtojek commented Jul 18, 2024

Crap, that's bad. I'm wondering if we shouldn't host it on our site rather than on GitHub. I don't know if these raw links are stable API.

Relies on coder/coder.com#518

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping
Copy link
Contributor Author

I've created https://github.com/coder/coder.com/pull/518 and referenced the new URL in 5a8331f
Once that's merged I'll merge this one

@dannykopping dannykopping merged commit 943ea7c into main Jul 19, 2024
37 checks passed
@dannykopping dannykopping deleted the dk/system-notifications-smtp branch July 19, 2024 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement auth & TLS for SMTP notification dispatcher
2 participants