Skip to content

chore: patch 2.12.4 #13925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2024
Merged

chore: patch 2.12.4 #13925

merged 3 commits into from
Jul 18, 2024

Conversation

stirby
Copy link
Collaborator

@stirby stirby commented Jul 17, 2024

Patching 2.12.3 -> 2.12.4

BrunoQuaresma and others added 2 commits July 17, 2024 19:09
* chore: add SVG desktop icon

* fix: add desktop icon to to icons.json

(cherry picked from commit 21a923a)
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really straightforward to me!

@Parkreiner
Copy link
Member

I'll make a quick fix for the formatting issues. Going to try re-running the test suite and see if it's a flake. If it passes, I'll open a new issue.

@Parkreiner
Copy link
Member

Going ahead with merge – seems some of the UI changes might have been a flake on Chromatic's part, as far as how it's handling some of the terminal elements?

@Parkreiner Parkreiner merged commit 82ed9e4 into release/2.12 Jul 18, 2024
26 of 27 checks passed
@Parkreiner Parkreiner deleted the patch/2.12.4 branch July 18, 2024 00:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants