feat: manage groups from deployment settings for single-org deployments #14016
Conversation
There was a problem hiding this comment.
Just to make sure I understand "single-org" in this context, that is with the multi-org experiment enabled but not licensed, right?
Should we redirect /groups to /deployment/groups (or /organizations/default/groups/ for multi-org?) similar to the users page? Probably not very important, but if someone has a bookmark or tries typing it manually maybe.
I think the create group page needs to take me to /deployment/groups/groupname rather than /organizations/default/groups/groupname with single-org since the latter gives me a blank sidebar (maybe a good place for another relative redirect).
Looks good so far!
| @@ -50,7 +50,7 @@ import { isEveryoneGroup } from "utils/groups"; | |||
| import { pageTitle } from "utils/page"; | |||
|
|
|||
| export const GroupPage: FC = () => { | |||
| const { organization, groupName } = useParams() as { | |||
| const { organization = "default", groupName } = useParams() as { | |||
There was a problem hiding this comment.
I see the constant "default" used in multiple places. We should define it in a const.ts file for consistency. Makes sense?
There was a problem hiding this comment.
personally, I really dread adding imports like that which end up being more typing that the thing you could just say directly
@code-asher I think it is also true when there is only one org created. |
|
No, a deployment which only has one org created but has a multi-org license is still a multi-org deployment. We need to show the "New organization" button, for example which is only present in the multi-org version of the UI. (and maintaining a 3rd version of the UI that's half single-org and half multi-org would be a gigantic pain) |
there are two license types now, and old/enterprise licenses no longer have access to org features. you can get a "premium" one from notion to test with. :) |
Closes #13957