Skip to content

chore(coderd): allow creating workspaces without specifying an organization #14048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jul 29, 2024

The organization can always be inferred from the template, which makes the parameter redundant. Templates are guaranteed to always belong to a single organization. The only purpose the organization parameter served in the old endpoint was a validation check to make sure that it matched the organization we inferred from the template.

  • Deprecate the old endpoint
  • Add a new endpoint at /users/{user}/workspaces [post]

@aslilac aslilac requested a review from Emyrk July 29, 2024 19:57
Copy link

alwaysmeticulous bot commented Jul 29, 2024

Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR.

Last updated for commit 708557d. This comment will update as new commits are pushed.

aslilac and others added 2 commits July 30, 2024 14:30
* chore: always use new codepath over deprecated
* add unit test for lack of template access
@aslilac aslilac merged commit bf4b7ab into main Jul 30, 2024
33 checks passed
@aslilac aslilac deleted the post-workspace-by-user branch July 30, 2024 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants