Skip to content

Update template method API #14097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dannykopping
Copy link
Contributor

Update template method API

Signed-off-by: Danny Kopping danny@coder.com

Template method update tests

Signed-off-by: Danny Kopping danny@coder.com

make gen

Signed-off-by: Danny Kopping danny@coder.com

Using "kind" not "is_system"

Signed-off-by: Danny Kopping danny@coder.com

Group routes in AGPL router

Signed-off-by: Danny Kopping danny@coder.com

Use PUT since this endpoint is idempotent

Signed-off-by: Danny Kopping danny@coder.com

Only use pg when necessary

Signed-off-by: Danny Kopping danny@coder.com

Fix notification settings test

Signed-off-by: Danny Kopping danny@coder.com

Copy link
Contributor Author

dannykopping commented Aug 1, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dannykopping and the rest of your teammates on Graphite Graphite

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
… kind

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Copy link

alwaysmeticulous bot commented Aug 1, 2024

✅ Meticulous spotted zero visual differences across 759 screens tested: view results.

Expected differences? Click here. Last updated for commit 7c06846. This comment will update as new commits are pushed.

@dannykopping dannykopping force-pushed the dk/notification-prefs/db branch from 3f4071c to 65e8546 Compare August 1, 2024 18:43
@dannykopping dannykopping force-pushed the dk/notification-prefs/admin-template-method branch 2 times, most recently from 3717c94 to 203ec6d Compare August 1, 2024 19:18
@dannykopping dannykopping changed the base branch from dk/notification-prefs/db to dk/notification-prefs/db-audit August 1, 2024 19:18
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the dk/notification-prefs/db-audit branch from 65f5aa7 to 8061685 Compare August 1, 2024 19:32
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the dk/notification-prefs/db-audit branch from 8061685 to b9f4ea6 Compare August 2, 2024 08:44
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the dk/notification-prefs/admin-template-method branch from 203ec6d to 7f9df56 Compare August 2, 2024 10:10
@dannykopping dannykopping force-pushed the dk/notification-prefs/db-audit branch 2 times, most recently from 85ec862 to 8333dcb Compare August 2, 2024 10:25
mtojek and others added 10 commits August 2, 2024 12:48
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the dk/notification-prefs/admin-template-method branch from 7f9df56 to 7c06846 Compare August 2, 2024 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@dannykopping dannykopping deleted the dk/notification-prefs/admin-template-method branch August 2, 2024 10:54
@dannykopping dannykopping restored the dk/notification-prefs/admin-template-method branch August 2, 2024 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants