Skip to content

feat: show a warning when an organization has no provisioners #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 2, 2024

Closes #13968

Screenshot 2024-08-02 at 2 22 17 PM

@aslilac
Copy link
Member Author

aslilac commented Aug 2, 2024

initially the query was more complicated and bespoke, so I inlined it, but I'm now realizing that it basically turned into a general provisioner daemons query with a select. I'll refactor this when I get back from lunch.

Copy link

alwaysmeticulous bot commented Aug 2, 2024

🤖 Meticulous spotted visual differences in 25 of 734 screens tested: view and approve differences detected.

Last updated for commit 9a3defe. This comment will update as new commits are pushed.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just think we should have a story to check if this warning is properly displayed when no provisioner is available.

@aslilac aslilac merged commit dfeafa8 into main Aug 5, 2024
32 checks passed
@aslilac aslilac deleted the provisioner-warning branch August 5, 2024 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioner disclaimer on the UI when no provisioners exist
3 participants