Skip to content

feat: show a warning when an organization has no provisioners #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2024
Merged

feat: show a warning when an organization has no provisioners #14136

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9e5c68
feat: show a warning when an organization has no provisioners
aslilac Aug 2, 2024
1d603d9
refactor a bit
aslilac Aug 2, 2024
0aa6e20
🧹
aslilac Aug 2, 2024
2f969b1
cleanup
aslilac Aug 5, 2024
9a3defe
Merge branch 'main' into provisioner-warning
aslilac Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🧹
  • Loading branch information
@aslilac
aslilac committed Aug 2, 2024
commit 0aa6e20672756079e6cf36a85f26c7e0878cb29d
17 changes: 2 additions & 15 deletions site/src/pages/CreateTemplatePage/CreateTemplateForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import Alert from "@mui/material/Alert";
import Link from "@mui/material/Link";
import TextField from "@mui/material/TextField";
import { useFormik } from "formik";
Expand All @@ -8,7 +7,6 @@ import { useState, type FC } from "react";
import { useQuery } from "react-query";
import { useSearchParams } from "react-router-dom";
import * as Yup from "yup";
import { API } from "api/api";
import { provisionerDaemons } from "api/queries/organizations";
import type {
Organization,
Expand All @@ -19,6 +17,7 @@ import type {
TemplateVersionVariable,
VariableValue,
} from "api/typesGenerated";
import { Alert } from "components/Alert/Alert";
import {
HorizontalForm,
FormSection,
Expand Down Expand Up @@ -216,18 +215,6 @@ export const CreateTemplateForm: FC<CreateTemplateFormProps> = (props) => {
});
const getFieldHelpers = getFormHelpers<CreateTemplateFormData>(form, error);

const warnAboutProvisionersQuery = useQuery({
enabled: showOrganizationPicker && Boolean(selectedOrg),
queryKey: ["warnAboutProvisioners", selectedOrg?.id],
queryFn: async () => {
const provisioners = await API.getProvisionerDaemonsByOrganization(
selectedOrg!.id,
);

return provisioners.length === 0;
},
});

const provisionerDaemonsQuery = useQuery(
selectedOrg
? {
Expand Down Expand Up @@ -407,7 +394,7 @@ const ProvisionerWarning: FC = () => {
return (
<Alert severity="warning" css={{ marginBottom: 16 }}>
This organization does not have any provisioners. Before you create a
template, you'll need to configure a provisioner.{" "}
template, you&apos;ll need to configure a provisioner.{" "}
<Link href={docs("/admin/provisioners#organization-scoped-provisioners")}>
See our documentation.
</Link>
Expand Down
Loading