fix: only show editable orgs on deployment page #14193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 528 of 1265 screens tested: view and approve differences detected. Last updated for commit ba22bc9. This comment will update as new commits are pushed. |
Also make sure the redirect from /organizations goes to an org that the user can edit, rather than always the default org.
f01285d to
713b954
Compare
|
If you cannot |
Emyrk
reviewed
Aug 7, 2024
Yup I want to do this, I was going to do it in a separate PR though! For now it shows an ineditable form, as before. |
Perfect 👍. Mainly just curious |
We show the org on the sidebar if they can edit anything, and we show each sub-link if they can view it, which means we were making both edit and view permission checks. Instead, show each link if they can edit it (not just view), which negates the need for separate view permissions. Incidentally, this also reduces the number of checks we need to make for individual pages, since some of them were only used on the sidebar.
92d15c5 to
475f6e2
Compare
This was referenced Aug 7, 2024
|
The new summary page: #14214 Kinda sad and sparse looking but hopefully better than an ineditable form 😛 |
caf0649 to
83bf388
Compare
aslilac
reviewed
Aug 7, 2024
site/src/pages/ManagementSettingsPage/OrganizationSettingsPage.tsx
Outdated
Show resolved
Hide resolved
aslilac
approved these changes
Aug 8, 2024
site/src/pages/ManagementSettingsPage/OrganizationSettingsPage.test.tsx
Outdated
Show resolved
Hide resolved
1d95c86 to
64631e1
Compare
5d9378b to
ba22bc9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure the redirect from /organizations goes to an org that the user can edit, rather than always the default org.