chore: remove UpsertCustomRole in favor of Insert + Update #14217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 35 of 1355 screens tested: view and approve differences detected. Last updated for commit 2d81996. This comment will update as new commits are pushed. |
28f3603 to
14da05a
Compare
|
@jaaydenh mentioned he needs to make a UI PR to migrate the UI to move away from upsert |
f0ssel
reviewed
Aug 9, 2024
Comment on lines
+220
to
+225
| switch createNewRole { | ||
| case true: | ||
| updated, err = client.CreateOrganizationRole(ctx, customRole) | ||
| default: | ||
| updated, err = client.UpdateOrganizationRole(ctx, customRole) | ||
| } |
There was a problem hiding this comment.
This feels like a smell to me, my gut would say that we should just have a separate create cli command. If the UI needs to make the distinction, sounds like we should do the same for the CLI.
There was a problem hiding this comment.
You are right @f0ssel. This PR is already quite big, and we are not launching this yet. Can I create an issue to split these out into 2 commands and do it in another PR?
f0ssel
approved these changes
Aug 9, 2024
14da05a to
c567a9d
Compare
* fix: use insert and update instead of upsert * fix: cleanup
05f1814 to
2d81996
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upsert was causing some ui issues, it is better to make these an explicit create or an update.
This was request by @jaaydenh to make the UI experience more fluid. Essentially you do not want to mistakenly create a role. A create and update should be explicit.