Skip to content

chore: improve forbidden error on create workspace without permissions #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 19, 2024

Multi-org enables the possibility of a user having template permissions, but not workspace create permissions. The unauthorized error should be returned instead of a 404. This does not leak any information the user cannot already obtain.

Screenshot from 2024-08-19 08-46-13

Requires: #14346
Closes: #14276

Multi-org enables the possibility of a user having template permissions,
but not workspace create permissions. The unauthorized error should be
returned instead of a 404. This does not leak any information the user
cannot already obtain.
@Emyrk Emyrk changed the title chore: forbidden error on create workspace without permissions chore: improve forbidden error on create workspace without permissions Aug 19, 2024
@Emyrk Emyrk requested a review from f0ssel August 19, 2024 17:42
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification about not leaking any already obtainable data. LGTM 👍

@Emyrk Emyrk merged commit 422e044 into main Aug 19, 2024
34 checks passed
@Emyrk Emyrk deleted the stevenmasley/workspace_permission_error branch August 19, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⭐ Bug: Better error message if you do not have create workspace permission
2 participants