feat: improve custom roles create/edit page #14456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Aug 27, 2024
| }), | ||
| actionItem: { | ||
| display: "grid", | ||
| gridTemplateColumns: "270px 3fr", |
There was a problem hiding this comment.
ultra nit: this could be 1fr since there aren't any other columns taking fractions
|
Minor design considerations: Screen.Recording.2024-08-28.at.09.40.48.mp4 |
I could add a storybook for the indeterminate state of the parent checkbox. What other types of tests are you thinking of? |
|
@BrunoQuaresma I added 2 additional stories for now, there is definitely a learning curve for figuring out the best way to query all the elements needed for the tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14311