Skip to content

fix: stop reporting future licenses as errors #14492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Aug 30, 2024

fixes #14476

Fixes the entitlements processing code so that we don't report existence of "future" licenses as an error, which might alarm admins needlessly. Downstack PR fixes our API to allow such licenses to be added to the database.

Copy link
Contributor Author

spikecurtis commented Aug 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis requested review from Emyrk and johnstcn August 30, 2024 08:01
@spikecurtis spikecurtis marked this pull request as ready for review August 30, 2024 08:01
@spikecurtis spikecurtis changed the base branch from spike/14476-post-license to graphite-base/14492 September 3, 2024 05:09
@spikecurtis spikecurtis force-pushed the spike/14476-future-errors branch from a937f2e to 5429e3c Compare September 3, 2024 05:09
@graphite-app graphite-app bot changed the base branch from graphite-base/14492 to main September 3, 2024 05:10
@spikecurtis spikecurtis merged commit 4eac2ac into main Sep 3, 2024
34 of 53 checks passed
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/14476-future-errors branch September 3, 2024 05:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admins have to stay up until midnight to apply a new license
3 participants