feat: generate golden files for notification templates #14537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Sep 4, 2024
dannykopping
reviewed
Sep 4, 2024
| require.NoError(t, err, "failed to render notification body template") | ||
| require.NotEmpty(t, body, "body should not be empty") | ||
|
|
||
| partialName := strings.Join(strings.Split(t.Name(), "/")[1:], "_") |
There was a problem hiding this comment.
Feels odd to have this in a test which is not explicitly for this purpose.
Can we split this out, rather?
There was a problem hiding this comment.
ok, let's rely depend on strings.Split
There was a problem hiding this comment.
Oh, sorry you interpreted what I said literally 😆
I meant splitting out the functionality into another test.
dannykopping
reviewed
Sep 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/internal#40
Changes:
export DB=ci, the simplest way is run./scripts/develop.shin background)MessagePayloadwithData map[string]anyNote: I believe our notification templates need some love in favor of spelling/formatting consistency. I will follow-up on this.