Skip to content

feat: generate golden files for notification templates #14537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Sep 4, 2024
Merged

feat: generate golden files for notification templates #14537

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b2523b1
WIP
mtojek Sep 3, 2024
9559138
WIP2
mtojek Sep 3, 2024
39d80eb
Template body
mtojek Sep 3, 2024
d9fef24
fmt
mtojek Sep 3, 2024
994f484
adjust payload
mtojek Sep 4, 2024
c55a688
fix
mtojek Sep 4, 2024
796da33
no index
mtojek Sep 4, 2024
c23da28
fix range
mtojek Sep 4, 2024
53dc29f
fix: base_url
mtojek Sep 4, 2024
1753beb
test
mtojek Sep 4, 2024
e200056
WIP
mtojek Sep 4, 2024
1118d67
WIP
mtojek Sep 4, 2024
7c7e0f9
WIP
mtojek Sep 4, 2024
ca0d9ee
s/bobby/Bobby/g
mtojek Sep 4, 2024
d91742c
gen
mtojek Sep 4, 2024
9fe5def
back to false
mtojek Sep 4, 2024
4d95288
fix
mtojek Sep 4, 2024
b12dcfc
Address PR feedback
mtojek Sep 4, 2024
412e9b2
db=ci
mtojek Sep 4, 2024
419c56a
golden
mtojek Sep 4, 2024
14ad9e8
fix
mtojek Sep 4, 2024
7587abc
split
mtojek Sep 4, 2024
f537d26
done
mtojek Sep 4, 2024
47c387b
fmt
mtojek Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
db=ci
  • Loading branch information
@mtojek
mtojek committed Sep 4, 2024
commit 412e9b27e900a954219ac22a794e8f556e469c68
2 changes: 1 addition & 1 deletion coderd/notifications/notifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ func TestNotificationTemplatesCanRender(t *testing.T) {
}

want, err := os.ReadFile(goldenFile)
require.NoError(t, err, "open golden file, run \"make update-golden-files\" and commit the changes")
require.NoError(t, err, "open golden file, run \"DB=ci make update-golden-files\" and commit the changes")
require.Equal(t, string(want), body, "body should be equal")
})
}
Expand Down
Loading