chore: refactor entry into deployment and runtime #14575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuntimeEntry has no startup value, and omits functions required to be serpent compatible.
dannykopping
approved these changes
Sep 5, 2024
| } | ||
|
|
||
| func NewMemoryCachedResolver(cache *syncmap.Map[string, cacheEntry], wrapped Resolver) *MemoryCachedResolver { | ||
| return &MemoryCachedResolver{ |
There was a problem hiding this comment.
Nit: panic here if cache is nil
There was a problem hiding this comment.
I think we should actually delete the cache resolver before we merge to main. Was just testing out some api usage with it.
| // Validate that it returns that value. | ||
| require.Equal(t, base.String(), field.String()) | ||
| // Validate that there is no org-level override right now. | ||
| _, err := field.Resolve(ctx, mgr.DeploymentResolver(db)) |
There was a problem hiding this comment.
Nit: DeploymentResolver feels like the wrong name; let's keep it for now but it's worth revisiting, I feel.
| // resolver from the manager. | ||
| // TODO: Delete MemoryCacheManager and implement it properly in 'StoreManager'. | ||
| type MemoryCacheManager struct { | ||
| cache *syncmap.Map[string, cacheEntry] |
There was a problem hiding this comment.
Nice! TIL about syncmap
Co-authored-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeploymentEntryhas noNew()function because it is always instantiated from aserpentcontext. There is no point to implementing aNew()function that will never be used in prod.Managerthat will be instantiated once for the app. TheManagerproducesResolverssuch that we can implement some shared cache.