fix: handle new agent stat format correctly #14576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
commented
Sep 18, 2024
There was a problem hiding this comment.
Looks good so far, would like us to ensure summing and filtering is checked a little deeper, but that shouldn't be too bad since the hard part of getting the mocks accurate is done. Have you tried running it in dev with the experiment on? You can try to repro the screenshot in the issue and see if you can data back.
f0ssel
commented
Sep 19, 2024
| @@ -150,7 +150,7 @@ func TestCache_BuildTime(t *testing.T) { | |||
| }, | |||
| }, | |||
| transition: database.WorkspaceTransitionStop, | |||
| }, want{50 * 1000, true}, | |||
There was a problem hiding this comment.
What makes this change needed?
There was a problem hiding this comment.
The old dbmem tryPercentile function was implemented slightly differently to how postgres implements PERCENTILE_CONT (although this test never gets run with postgres anyway)
ethanndickson
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14348