Skip to content

feat: show tags for psk provisioners #14628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 17, 2024
Merged

feat: show tags for psk provisioners #14628

merged 17 commits into from
Sep 17, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 9, 2024

Closes #14441

@aslilac aslilac linked an issue Sep 13, 2024 that may be closed by this pull request
5 tasks
@aslilac aslilac assigned Parkreiner and unassigned Parkreiner Sep 17, 2024
@aslilac aslilac requested a review from Parkreiner September 17, 2024 18:10
@aslilac aslilac marked this pull request as ready for review September 17, 2024 18:11
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a pretty straightforward refactor to me. Approving

padding: "12px 18px",
width: 310,
padding: "14px 18px",
width: 375,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the width be swapped out for flex-basis?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda don't want them to grow tho, and disrupt the "grid"

Base automatically changed from provisioner-types to main September 17, 2024 21:20
@aslilac aslilac merged commit 5be02a2 into main Sep 17, 2024
27 checks passed
@aslilac aslilac deleted the psk-tags branch September 17, 2024 21:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui(provisioners): show tags for PSK provisioners
2 participants